Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): minor adjustments to with-shell-commands #9219

Merged
merged 3 commits into from
Oct 8, 2024
Merged

chore(examples): minor adjustments to with-shell-commands #9219

merged 3 commits into from
Oct 8, 2024

Conversation

breadadams
Copy link
Contributor

Description

  • Rename the app directories from apps/apps-* → apps/app-*.
  • Fix a typo

Testing Instructions

N/A

@breadadams breadadams requested a review from a team as a code owner October 3, 2024 21:36
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Oct 3, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 10:27pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 10:27pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 10:27pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 10:27pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 10:27pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 10:27pm

@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024

@breadadams is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

anthonyshew
anthonyshew reviewed Oct 5, 2024
View reviewed changes
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it does make more sense that way! 😄

Just checking, is there a pnpm lockfile update needed as well? Usually, when you rename directories, you'll need to fix the lockfile. Was that not the case here?

@breadadams
Copy link
Contributor Author

Ah good point, missed that! Thanks @anthonyshew, will update the PR Monday - travelling currently.

@breadadams breadadams requested a review from anthonyshew October 7, 2024 22:28
anthonyshew
anthonyshew approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional fixes!

@anthonyshew anthonyshew merged commit 7191ff3 into vercel:main Oct 8, 2024
10 of 13 checks passed
@anthonyshew anthonyshew mentioned this pull request Oct 22, 2024
Merged
@Lavish1999 Lavish1999 mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyshew anthonyshew anthonyshew approved these changes

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@breadadams @anthonyshew