-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(watch): add interruptible tasks #9228
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
4993179
to
e9f71fa
Compare
…hout it being persistent
e9f71fa
to
22b297c
Compare
But only when |
No, the change is true for all tasks. I don't want to make too many special cases for watch mode execution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this now allows for persistent tasks to only run after their deps run which has also been an ask (#8673). Should we advertise this/consider this when naming the config option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!
If we ever enable caching during watch
I believe we need to verify that cache: false
on interruptible tasks, but since that isn't possible now it's fine.
Hmm, looks like the JSON schema was not updated with the new field added here. |
Description
Adds the ability to annotate persistent tasks as interruptible. Fixes #8164.
NOTE: This does create change in behavior for watch mode where new changes will stop the current executing and start a new one. Previously, we waited for runs to finish, but now that persistent tasks can be interrupted, we can't do that since persistent tasks don't finish.
Testing Instructions
Added tests for ensuring that
interruptible
requirespersistent
, but otherwise you'll have to try this out manually since it's watch mode.