refactor(test): rust integration tests #9314
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
NicholasLYang
force-pushed
the
refactor/add-more-rust-integration-tests
branch
from
1f4c693 to
6163e2d
Compare
| .output()?; | ||
|
|
||
| let stdout = String::from_utf8(output.stdout)?; | ||
| let query_output: serde_json::Value = serde_json::from_str(&stdout)?; |
There was a problem hiding this comment.
Might be worth changing the macro name/doc comments to make it clear this is useful only for commands that produce JSON output
There was a problem hiding this comment.
Minor, but there still isn't mention in the doc comment or macro name that this is for JSON command only.
| $name.replace(' ', "_"), | ||
| $package_manager | ||
| ); | ||
| insta::assert_json_snapshot!(test_name, query_output); |
There was a problem hiding this comment.
Can we put each of these asserts in it's own test? Currently if the first test case fails, none of the other ones will run. Prysk will continue running if one of the commands doesn't produce matching output.
There was a problem hiding this comment.
Is there a way to do this while also using the same fixture? I don't want to spin up a fixture for each test. Insta does also let you do the prysk behavior with cargo insta test --review or INSTA_FORCE_PASS=1 cargo test --no-fail-fast
There was a problem hiding this comment.
I suppose we'd have to store the tempfile in something like a static ref and have special cleanup logic. I think eventually we'll want beforeAll/afterAll behavior to make debugging failures easier. ITG
There was a problem hiding this comment.
Insta does also let you do the prysk behavior with cargo insta test --review or INSTA_FORCE_PASS=1 cargo test --no-fail-fast
I don't think these do what we want, INSTA_FORCE_PASS=1 seems to just forcibly pass all snapshot assertions without printing any diffs. cargo insta test --review is just equivalent to --interactive in prysk.
There was a problem hiding this comment.
According to this those are the recommended ways to not fail on the first test
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
crates/turborepo/tests/common/mod.rs
Outdated
|
|
||
| pub fn setup_fixture( | ||
| fixture: &str, | ||
| package_manager: Option<&str>, |
There was a problem hiding this comment.
suggestion: it would be nice to keep this explicit so it's really clear from looking at the test what it's gonna run with. or, if not, it'd be nice if there was some way to make check! variadic (is there?).
| $name.replace(' ', "_"), | ||
| $package_manager | ||
| ); | ||
| insta::assert_json_snapshot!(test_name, query_output); |
There was a problem hiding this comment.
I suppose we'd have to store the tempfile in something like a static ref and have special cleanup logic. I think eventually we'll want beforeAll/afterAll behavior to make debugging failures easier. ITG
| .output()?; | ||
|
|
||
| let stdout = String::from_utf8(output.stdout)?; | ||
| let query_output: serde_json::Value = serde_json::from_str(&stdout)?; |
There was a problem hiding this comment.
Minor, but there still isn't mention in the doc comment or macro name that this is for JSON command only.
| $name.replace(' ', "_"), | ||
| $package_manager | ||
| ); | ||
| insta::assert_json_snapshot!(test_name, query_output); |
There was a problem hiding this comment.
Insta does also let you do the prysk behavior with cargo insta test --review or INSTA_FORCE_PASS=1 cargo test --no-fail-fast
I don't think these do what we want, INSTA_FORCE_PASS=1 seems to just forcibly pass all snapshot assertions without printing any diffs. cargo insta test --review is just equivalent to --interactive in prysk.
| expression: stderr | ||
| --- | ||
| WARNING No locally installed `turbo` found. Using version: 2.2.4-canary.0. | ||
| turbo 2.2.4-canary.0 |
There was a problem hiding this comment.
We don't want to capture this since we always use newest turbo version
Description
Fleshing out the rust integration tests. Added a macro for creating an integration test. The macro isn't perfect since it doesn't support running non-turbo commands for setup, and multiple arguments aren't implemented.
Testing Instructions