Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): allow force to override any cache settings #9454

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

chris-olszewski
Copy link
Member

Description

As mentioned in #9453 if a user sets --force when TURBO_CACHE is set we currently error. --force should be applicable in this case an just remove any reads from the TURBO_CACHE setting.

Testing Instructions

Updated unit test, manual verification of behavior for other cases:

# Do not allow `--force` and `--cache`
[0 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ turbo_dev @turbo/types#build --force --cache=local:rw 
 WARNING  No locally installed `turbo` found. Using version: 2.3.1-canary.0.
 ERROR  the argument '--force [<FORCE>]' cannot be used with '--cache <CACHE>'

Usage: turbo --force [<FORCE>]

For more information, try '--help'.

# Force should remove reads even if set from env var
[1 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ TURBO_FORCE=1 turbo_dev @turbo/types#build --cache=local:rw       
 WARNING  No locally installed `turbo` found. Using version: 2.3.1-canary.0.
turbo 2.3.1-canary.0

• Packages in scope: @turbo-internal/top-issues-gh-action, @turbo/benchmark, @turbo/codemod, @turbo/eslint-config, @turbo/exe-stub, @turbo/gen, @turbo/telemetry, @turbo/test-utils, @turbo/tsconfig, @turbo/types, @turbo/utils, @turbo/workspaces, @turborepo-examples-tests/basic, @turborepo-examples-tests/design-system, @turborepo-examples-tests/kitchen-sink, @turborepo-examples-tests/non-monorepo, @turborepo-examples-tests/with-berry, @turborepo-examples-tests/with-changesets, @turborepo-examples-tests/with-npm, @turborepo-examples-tests/with-react-native-web, @turborepo-examples-tests/with-rollup, @turborepo-examples-tests/with-svelte, @turborepo-examples-tests/with-tailwind, @turborepo-examples-tests/with-vite, @turborepo-examples-tests/with-yarn, cargo-sweep-action, cli, create-turbo, eslint-config-turbo, eslint-plugin-turbo, prysk, turbo-ignore, turbo-vsc, turborepo-examples, turborepo-repository, turborepo-tests-helpers, turborepo-tests-integration
• Running @turbo/types#build in 37 packages
• Remote caching disabled
┌ @turbo/types#build > cache bypass, force executing 378250748b4bc15b 
│ 
│ 
│ > @turbo/types@2.3.1-canary.0 build /Users/olszewski/code/vercel/turborepo/packages/turbo-types
│ > tsc && pnpm generate-schema
│ 
│ 
│ > @turbo/types@2.3.1-canary.0 generate-schema /Users/olszewski/code/vercel/turborepo/packages/turbo-types
│ > tsx scripts/generate-schema.ts
└────>

 Tasks:    1 successful, 1 total
Cached:    0 cached, 1 total
  Time:    3.045s 

# `--force` removes reads from `TURBO_CACHE` settings
[0 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ TURBO_CACHE=local:rw turbo_dev @turbo/types#build --force         
 WARNING  No locally installed `turbo` found. Using version: 2.3.1-canary.0.
turbo 2.3.1-canary.0

• Packages in scope: @turbo-internal/top-issues-gh-action, @turbo/benchmark, @turbo/codemod, @turbo/eslint-config, @turbo/exe-stub, @turbo/gen, @turbo/telemetry, @turbo/test-utils, @turbo/tsconfig, @turbo/types, @turbo/utils, @turbo/workspaces, @turborepo-examples-tests/basic, @turborepo-examples-tests/design-system, @turborepo-examples-tests/kitchen-sink, @turborepo-examples-tests/non-monorepo, @turborepo-examples-tests/with-berry, @turborepo-examples-tests/with-changesets, @turborepo-examples-tests/with-npm, @turborepo-examples-tests/with-react-native-web, @turborepo-examples-tests/with-rollup, @turborepo-examples-tests/with-svelte, @turborepo-examples-tests/with-tailwind, @turborepo-examples-tests/with-vite, @turborepo-examples-tests/with-yarn, cargo-sweep-action, cli, create-turbo, eslint-config-turbo, eslint-plugin-turbo, prysk, turbo-ignore, turbo-vsc, turborepo-examples, turborepo-repository, turborepo-tests-helpers, turborepo-tests-integration
• Running @turbo/types#build in 37 packages
• Remote caching disabled
┌ @turbo/types#build > cache bypass, force executing 378250748b4bc15b 
│ 
│ 
│ > @turbo/types@2.3.1-canary.0 build /Users/olszewski/code/vercel/turborepo/packages/turbo-types
│ > tsc && pnpm generate-schema
│ 
│ 
│ > @turbo/types@2.3.1-canary.0 generate-schema /Users/olszewski/code/vercel/turborepo/packages/turbo-types
│ > tsx scripts/generate-schema.ts
└────>

 Tasks:    1 successful, 1 total
Cached:    0 cached, 1 total
  Time:    2.284s 

@chris-olszewski chris-olszewski marked this pull request as ready for review November 18, 2024 15:38
@chris-olszewski chris-olszewski requested a review from a team as a code owner November 18, 2024 15:38
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 3:38pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Nov 18, 2024 3:38pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Nov 18, 2024 3:38pm
examples-gatsby-web ⬜️ Ignored (Inspect) Nov 18, 2024 3:38pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Nov 18, 2024 3:38pm
examples-native-web ⬜️ Ignored (Inspect) Nov 18, 2024 3:38pm
examples-svelte-web ⬜️ Ignored (Inspect) Nov 18, 2024 3:38pm
examples-tailwind-web ⬜️ Ignored (Inspect) Nov 18, 2024 3:38pm
examples-vite-web ⬜️ Ignored (Inspect) Nov 18, 2024 3:38pm

@chris-olszewski chris-olszewski merged commit 0ecfa3b into main Nov 18, 2024
40 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/fix_gh_9453 branch November 18, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants