-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tui): Improve aesthetics for helper text. #9478
Merged
Merged
+23
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anthonyshew
changed the title
refactor(tui): Gain better aesthetic for helper text.
refactor(tui): Gain better aesthetic for helper text and add Nov 21, 2024
i
for interacting.
anthonyshew
changed the title
refactor(tui): Gain better aesthetic for helper text and add
refactor(tui): Gain better aesthetic for helper text.
Nov 21, 2024
i
for interacting.
chris-olszewski
approved these changes
Nov 21, 2024
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
anthonyshew
commented
Nov 21, 2024
anthonyshew
changed the title
refactor(tui): Gain better aesthetic for helper text.
refactor(tui): Improve aesthetics for helper text.
Nov 21, 2024
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just wanting to spruce things up a bit.
In the process of adjusting the text with a comma as a separator, I realized I could refactor the logic for which text to render to be a little easier to read. Isn't it great when the simplicity of the visual design is reflected in the code?!
Testing Instructions
You'll want to put the TUI into different states to see them all. Matrix is:
A sample of the spirit of the changes is below.
Before
After