Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tui): Improve aesthetics for helper text. #9478

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Nov 21, 2024

Description

Just wanting to spruce things up a bit.

  • Left-aligned the text so that it bounces around less when changing states. This is considered a generally good practice in UI design.
  • Re-writing text chunks for simplicity

In the process of adjusting the text with a comma as a separator, I realized I could refactor the logic for which text to render to be a little easier to read. Isn't it great when the simplicity of the visual design is reflected in the code?!

Testing Instructions

You'll want to put the TUI into different states to see them all. Matrix is:

  • Task list open/closed
  • Text selected/not selected
  • Task being interacted with/ not interacted with

A sample of the spirit of the changes is below.

Before
CleanShot 2024-11-20 at 23 05 58@2x

After
CleanShot 2024-11-20 at 23 06 38@2x

@anthonyshew anthonyshew requested a review from a team as a code owner November 21, 2024 06:05
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 7:59pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 7:59pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 7:59pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 7:59pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 7:59pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 7:59pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 7:59pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 7:59pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 7:59pm

@anthonyshew anthonyshew changed the title refactor(tui): Gain better aesthetic for helper text. refactor(tui): Gain better aesthetic for helper text and add i for interacting. Nov 21, 2024
@anthonyshew anthonyshew changed the title refactor(tui): Gain better aesthetic for helper text and add i for interacting. refactor(tui): Gain better aesthetic for helper text. Nov 21, 2024
crates/turborepo-ui/src/tui/pane.rs Outdated Show resolved Hide resolved
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants