-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tui): persistent preferences #9512
Merged
+351
−22
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
571b719
refactor(tui): move vim keybinds for task list in handle list.
anthonyshew 6d1a886
wip
anthonyshew ba8cc9a
WIP
anthonyshew a6c1ae1
WIP
anthonyshew 191a5f8
Merge branch 'main' into shew-244ce
anthonyshew 7fdd3c5
WIP
anthonyshew 83cee6b
WIP
anthonyshew 40e4f18
WIP
anthonyshew 1eb597e
WIP
anthonyshew b685346
WIP
anthonyshew 78bb0b6
WIP
anthonyshew 0e65fa3
WIP
anthonyshew b13f8a9
WIP
anthonyshew c00b7ed
WIP
anthonyshew d0f0186
WIP
anthonyshew 4207f09
WIP
anthonyshew aad4664
WIP
anthonyshew 2bf8f96
WIP
anthonyshew 0f8f92d
WIP
anthonyshew 8168cb2
WIP
anthonyshew 4a8c01e
WIP
anthonyshew fecc8ad
Merge branch 'main' into shew-244ce
anthonyshew 04f715d
WIP
anthonyshew 577480e
Merge branch 'shew-244ce' of https://github.com/vercel/turborepo into…
anthonyshew 00b6b0e
Update crates/turborepo-ui/src/tui/app.rs
anthonyshew 63b3e77
WIP
anthonyshew a270d7a
Merge branch 'shew-244ce' of https://github.com/vercel/turborepo into…
anthonyshew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -262,8 +262,9 @@ impl Run { | |||||
|
||||||
let (sender, receiver) = TuiSender::new(); | ||||||
let color_config = self.color_config; | ||||||
let repo_root = self.repo_root.clone(); | ||||||
chris-olszewski marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can just borrow here instead of cloning
Suggested change
|
||||||
let handle = tokio::task::spawn(async move { | ||||||
Ok(tui::run_app(task_names, receiver, color_config).await?) | ||||||
Ok(tui::run_app(task_names, receiver, color_config, &repo_root).await?) | ||||||
}); | ||||||
|
||||||
Ok(Some((sender, handle))) | ||||||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.