-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tui): popup to list keybinds #9545
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
I think not blocking inputs is good. Do you think closing the popup on key interactions would be intuitive?
Not easily. If we swapped from a |
I played around with this, and I was discovering more inventive workflows than ever with keeping it open. It felt like I could get inspired about my next move more. However, I could also see this as "I checked the binds for the thing I wanted and I pushed it. Now go away." as a more experienced user. I don't think I have a strong opinion; I could see either behavior being useful depending on who you are. If I were forced to pick, I would keep it as-is (not auto-close).
Agree that this shouldn't block and hard to say if its YAGNI. I can explore options in follow-up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ITG
Description
We're adding a host of binds to make the TUI even more useful, and listing them out with our current strategy is going to prove cumbersome quickly. Terminal real estate is valuable!
With this PR, we're putting in a popup that you can use to quickly get a glance of what's available to you.
Testing Instructions
Try it out!
Questions
input.rs
?