Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(watch): watch command require tasks argument #9598

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(watch): watch command require tasks argument #9598

merged 1 commit into from
Dec 11, 2024
+7 −2

Conversation

takaebato
Copy link
Contributor

Description

Testing Instructions

@takaebato takaebato requested a review from a team as a code owner December 10, 2024 14:01
@turbo-orchestrator turbo-orchestrator bot added the needs: triage New issues get this label. Remove it after triage label Dec 10, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:47pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:47pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:47pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:47pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:47pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:47pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:47pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:47pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:47pm

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024

@takaebato is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@chris-olszewski chris-olszewski linked an issue Dec 11, 2024 that may be closed by this pull request
watch should require a task #9446
Closed
1 task
@ijjk
Copy link
Member

ijjk commented Dec 11, 2024 •
edited by chris-olszewski
Loading

Allow CI Workflow Run

  • approve CI run for commit: f17e234

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@chris-olszewski chris-olszewski removed the needs: triage New issues get this label. Remove it after triage label Dec 11, 2024
@turbo-orchestrator turbo-orchestrator bot added the needs: triage New issues get this label. Remove it after triage label Dec 11, 2024
@chris-olszewski chris-olszewski changed the title [WIP] Make watch command require tasks argument fix(watch): watch command require tasks argument Dec 11, 2024
chris-olszewski
chris-olszewski approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@chris-olszewski chris-olszewski merged commit ffd4679 into vercel:main Dec 11, 2024
35 of 36 checks passed
@anthonyshew anthonyshew mentioned this pull request Dec 12, 2024
Merged
@takaebato takaebato mentioned this pull request Dec 12, 2024
Merged
anthonyshew added a commit that referenced this pull request Dec 12, 2024
@takaebato @anthonyshew
fix(watch): fix output text when no tasks are provided (#9612)
e2d4e6c 
Additional fixes for #9598

### Description

- Unified output texts from `some potential ones to run` to `some
potential ones` across both run and watch commands when no tasks are
provided. Let me know if there is a better way!
- Added documentation and tests.

### Testing Instructions

Added integration tests.

Co-authored-by: Anthony Shew <anthony.shew@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-olszewski chris-olszewski chris-olszewski approved these changes

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
needs: triage New issues get this label. Remove it after triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

watch should require a task
3 participants
@takaebato @ijjk @chris-olszewski