[build-utils] Remove VERCEL_ENABLE_NPM_DEFAULT env var check
#11242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flag has been rolled out for long enough at this point. npm will now always be used as the package manager when no lockfile is present.
🦋 Changeset detectedLatest commit: f1bf999 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
EndangeredMassa
approved these changes
Mar 7, 2024
EndangeredMassa
added
the
pending-merge
trek
approved these changes
Mar 7, 2024
Merged
EndangeredMassa
pushed a commit
that referenced
this pull request
Mar 8, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/build-utils@7.8.0 ### Minor Changes - Remove `VERCEL_ENABLE_NPM_DEFAULT` env var check ([#11242](#11242)) ### Patch Changes - Rename variants to flags and remove legacy flags ([#11121](#11121)) ## vercel@33.5.5 ### Patch Changes - Rename variants to flags and remove legacy flags ([#11121](#11121)) - fix vc with root dir issues ([#11243](#11243)) - Updated dependencies \[[`908e7837d`](908e783), [`5e3656ec1`](5e3656e), [`a53d1b0d3`](a53d1b0)]: - @vercel/build-utils@7.8.0 - @vercel/next@4.1.5 - @vercel/remix-builder@2.1.2 - @vercel/node@3.0.22 - @vercel/static-build@2.4.2 ## @vercel/client@13.1.5 ### Patch Changes - Updated dependencies \[[`908e7837d`](908e783), [`5e3656ec1`](5e3656e)]: - @vercel/build-utils@7.8.0 ## @vercel/gatsby-plugin-vercel-builder@2.0.20 ### Patch Changes - Updated dependencies \[[`908e7837d`](908e783), [`5e3656ec1`](5e3656e)]: - @vercel/build-utils@7.8.0 ## @vercel/next@4.1.5 ### Patch Changes - Rename variants to flags and remove legacy flags ([#11121](#11121)) ## @vercel/node@3.0.22 ### Patch Changes - Updated dependencies \[[`908e7837d`](908e783), [`5e3656ec1`](5e3656e)]: - @vercel/build-utils@7.8.0 ## @vercel/remix-builder@2.1.2 ### Patch Changes - Update `@remix-run/dev` fork to v2.8.1 ([#11241](#11241)) ## @vercel/static-build@2.4.2 ### Patch Changes - Updated dependencies \[]: - @vercel/gatsby-plugin-vercel-builder@2.0.20 ## @vercel-internals/types@1.0.25 ### Patch Changes - Updated dependencies \[[`908e7837d`](908e783), [`5e3656ec1`](5e3656e)]: - @vercel/build-utils@7.8.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
styfle
added a commit
to vercel/next.js
that referenced
this pull request
Apr 25, 2024
…ependency (#63321) ## History Previously, we added support for `squoosh` because it was a wasm implementation that "just worked" on all platforms when running `next dev` for the first time. However, it was slow so we always recommended manually installing `sharp` for production use cases running `next build` and `next start`. Now that [`sharp` supports webassembly](https://sharp.pixelplumbing.com/install#webassembly), we no longer need to maintain `squoosh`, so it can be removed. We also don't need to make the user install sharp manually because it can be installed under `optionalDependencies`. I left it optional in case there was some platform that still needed to manually install the wasm variant with `npm install --cpu=wasm32 sharp` such as codesandbox/stackblitz (I don't believe sharp has any fallback built in yet). Since we can guarantee `sharp`, we can also remove `get-orientation` dep and upgrade `image-size` dep. I also moved an [existing `sharp` test](#56674) into its own fixture since it was unrelated to image optimization. ## Related Issues - Fixes #41417 - Related #54670 - Related #54708 - Related #44804 - Related #48820 - Related #61810 - Related #61696 - Related #44685 - Closes #64362 ## Breaking Change This is a breaking change because newer versions of `sharp` no longer support `yarn@1`. - lovell/sharp#3750 The workaround is to install with `yarn --ignore-engines` flag. Also note that Vercel no longer defaults to yarn when no lockfile is found - vercel/vercel#11131 - vercel/vercel#11242 Closes NEXT-2823
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
…ependency (#63321) ## History Previously, we added support for `squoosh` because it was a wasm implementation that "just worked" on all platforms when running `next dev` for the first time. However, it was slow so we always recommended manually installing `sharp` for production use cases running `next build` and `next start`. Now that [`sharp` supports webassembly](https://sharp.pixelplumbing.com/install#webassembly), we no longer need to maintain `squoosh`, so it can be removed. We also don't need to make the user install sharp manually because it can be installed under `optionalDependencies`. I left it optional in case there was some platform that still needed to manually install the wasm variant with `npm install --cpu=wasm32 sharp` such as codesandbox/stackblitz (I don't believe sharp has any fallback built in yet). Since we can guarantee `sharp`, we can also remove `get-orientation` dep and upgrade `image-size` dep. I also moved an [existing `sharp` test](#56674) into its own fixture since it was unrelated to image optimization. ## Related Issues - Fixes #41417 - Related #54670 - Related #54708 - Related #44804 - Related #48820 - Related #61810 - Related #61696 - Related #44685 - Closes #64362 ## Breaking Change This is a breaking change because newer versions of `sharp` no longer support `yarn@1`. - lovell/sharp#3750 The workaround is to install with `yarn --ignore-engines` flag. Also note that Vercel no longer defaults to yarn when no lockfile is found - vercel/vercel#11131 - vercel/vercel#11242 Closes NEXT-2823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag has been rolled out for long enough at this point.
npm will now always be used as the package manager when no lockfile is present.