-
Notifications
You must be signed in to change notification settings - Fork 88
feat: add Nuxt module and documentation #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 8a164fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 Build Fix:
The Nuxt module incorrectly references 'workflow/nitro' when registering a Nitro module, but it should reference '@workflow/nitro' directly to avoid module resolution issues during the build process.
View Details
📝 Patch Details
diff --git a/packages/nuxt/src/module.ts b/packages/nuxt/src/module.ts
index 1002d59..9777a12 100644
--- a/packages/nuxt/src/module.ts
+++ b/packages/nuxt/src/module.ts
@@ -14,8 +14,8 @@ export default defineNuxtModule<ModuleOptions>({
setup(_options, nuxt) {
nuxt.options.nitro ||= {};
nuxt.options.nitro.modules ||= [];
- if (!nuxt.options.nitro.modules.includes('workflow/nitro')) {
- nuxt.options.nitro.modules.push('workflow/nitro');
+ if (!nuxt.options.nitro.modules.includes('@workflow/nitro')) {
+ nuxt.options.nitro.modules.push('@workflow/nitro');
}
},
});
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index b305d06..1542d93 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -516,6 +516,9 @@ importers:
'@workflow/nitro':
specifier: workspace:*
version: link:../nitro
+ workflow:
+ specifier: workspace:*
+ version: link:../workflow
devDependencies:
'@nuxt/module-builder':
specifier: ^1.0.2
Analysis
Nuxt build fails due to incorrect module reference
What fails: The @workflow/nuxt package build fails during the nuxt-module-build step when trying to resolve the module 'workflow/nitro'
How to reproduce:
cd packages/nuxt
pnpm run buildResult:
ERROR Cannot find module '/vercel/sandbox/primary/node_modules/.pnpm/node_modules/workflow/dist/nitro.js'The error occurs because the Nuxt module tries to register 'workflow/nitro' as a Nitro module, but should reference '@workflow/nitro' directly instead.
Add support for
workflow/nuxt:Added documentation page + updated landing page for available frameworks.