Web: smooth trace-viewer animations for live mode #248
Conversation
🦋 Changeset detectedLatest commit: b621180 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
VaguelySerious
changed the title
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔧 Build Fix:
The ./components/ui/skeleton module was missing, causing a TypeScript import error in workflow-trace-view.tsx. The component is used to display loading skeletons with className prop support.
View Details
📝 Patch Details
diff --git a/packages/web-shared/src/components/ui/skeleton.tsx b/packages/web-shared/src/components/ui/skeleton.tsx
new file mode 100644
index 0000000..0186ec0
--- /dev/null
+++ b/packages/web-shared/src/components/ui/skeleton.tsx
@@ -0,0 +1,15 @@
+import { cn } from '../../lib/utils';
+
+function Skeleton({
+ className,
+ ...props
+}: React.HTMLAttributes<HTMLDivElement>) {
+ return (
+ <div
+ className={cn('animate-pulse rounded-md bg-muted', className)}
+ {...props}
+ />
+ );
+}
+
+export { Skeleton };
\ No newline at end of file
Analysis
Missing skeleton component causes TypeScript compilation failure
What fails: TypeScript compiler fails on packages/web-shared/src/workflow-trace-view.tsx due to missing skeleton component import
How to reproduce:
cd packages/web-shared && pnpm run buildResult:
src/workflow-trace-view.tsx(5,26): error TS2307: Cannot find module './components/ui/skeleton' or its corresponding type declarations.
…web-animation-fast
VaguelySerious
changed the base branch from
main
to
peter/web-load-optimize-and-cli-flag-fixes
There was a problem hiding this comment.
🔧 Build Fix:
The useState hook is imported from React but never used in the component, causing a TypeScript compilation error due to the noUnusedLocals setting.
View Details
📝 Patch Details
diff --git a/packages/web-shared/src/workflow-trace-view.tsx b/packages/web-shared/src/workflow-trace-view.tsx
index 47987df..3152953 100644
--- a/packages/web-shared/src/workflow-trace-view.tsx
+++ b/packages/web-shared/src/workflow-trace-view.tsx
@@ -1,5 +1,5 @@
import type { Event, Hook, Step, WorkflowRun } from '@workflow/world';
-import { useEffect, useMemo, useState } from 'react';
+import { useEffect, useMemo } from 'react';
import { toast } from 'sonner';
import type { EnvMap } from './api/workflow-server-actions';
import { Skeleton } from './components/ui/skeleton';
Analysis
Unused import causes TypeScript compilation failure
What fails: TypeScript compiler fails on packages/web-shared/src/workflow-trace-view.tsx due to unused useState import
How to reproduce:
cd packages/web-shared && npx tsc --noEmitResult:
src/workflow-trace-view.tsx(2,30): error TS6133: 'useState' is declared but its value is never read.
No description provided.