feat(world-local): add baseUrl config and improve port handling #260

aryasaatvik · 2025-11-07T13:00:53Z

Add baseUrl configuration and improve port handling

This PR adds baseUrl configuration support to enable HTTPS and custom hostnames in local development, while maintaining automatic port detection as a fallback.

Key Features

BaseUrl override:

Configure via baseUrl config option or WORKFLOW_EMBEDDED_BASE_URL env var
Enables HTTPS development (next dev --experimental-https)
Supports custom hostnames (e.g., https://local.example.com:3000)

Port resolution priority:

config.baseUrl (full override)
config.port (explicit port)
Auto-detected port via @workflow/utils/get-port
PORT env var
Default to 3000

Breaking Changes

API signature updated:

// Before
createEmbeddedWorld(dataDir?: string, port?: number)

// After  
createEmbeddedWorld(args?: Partial<Config>)

Closes #233
Closes #245

changeset-bot · 2025-11-07T13:00:56Z

🦋 Changeset detected

Latest commit: 94d5e51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@workflow/world-local	Major
@workflow/cli	Patch
@workflow/core	Patch
@workflow/world-postgres	Patch
workflow	Patch
@workflow/world-testing	Patch
@workflow/builders	Patch
@workflow/next	Patch
@workflow/nitro	Patch
@workflow/web-shared	Patch
@workflow/ai	Patch
@workflow/sveltekit	Patch
@workflow/nuxt	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-11-07T13:00:59Z

@aryasaatvik is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

I, Saatvik Arya <aryasaatvik@gmail.com>, hereby add my Signed-off-by to this commit: 27a12f4 I, Saatvik Arya <aryasaatvik@gmail.com>, hereby add my Signed-off-by to this commit: 34039c3 Signed-off-by: Saatvik Arya <aryasaatvik@gmail.com>

packages/core/src/util.test.ts

…ion and config Signed-off-by: Saatvik Arya <aryasaatvik@gmail.com>

pranaygp · 2025-11-08T14:58:26Z

since #233 was merged, could you please rebase/merge this PR on main? this or includes a number of commits from @adriandlam

I, Saatvik Arya <aryasaatvik@gmail.com>, hereby add my Signed-off-by to this commit: 195a7ae I, Saatvik Arya <aryasaatvik@gmail.com>, hereby add my Signed-off-by to this commit: 414aa4c I, Saatvik Arya <aryasaatvik@gmail.com>, hereby add my Signed-off-by to this commit: 7b81781 Signed-off-by: Saatvik Arya <aryasaatvik@gmail.com>

packages/world-local/src/config.ts

- Change port check from truthiness to `typeof === 'number'` - Port 0 (OS-assigned port) now works correctly instead of being skipped - Null values properly fall through to auto-detection - Add tests for port 0 and null edge cases Signed-off-by: Saatvik Arya <aryasaatvik@gmail.com>

The createEmbeddedWorld API signature change is breaking: - Before: createEmbeddedWorld(dataDir?, port?) - After: createEmbeddedWorld(args?: Partial<Config>) Signed-off-by: Saatvik Arya <aryasaatvik@gmail.com>

These were bugs introduced and fixed within the same PR, not pre-existing bugs, so they shouldn't be listed as fixes. Signed-off-by: Saatvik Arya <aryasaatvik@gmail.com>

Automatic port detection already existed in main via getPort(). This PR only adds baseUrl config and port 0 support. Signed-off-by: Saatvik Arya <aryasaatvik@gmail.com>

vercel · 2025-11-11T04:59:25Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
example-nextjs-workflow-turbopack	Ready	Preview	Comment	Nov 13, 2025 6:50pm
example-nextjs-workflow-webpack	Ready	Preview	Comment	Nov 13, 2025 6:50pm
example-workflow	Ready	Preview	Comment	Nov 13, 2025 6:50pm
workbench-hono-workflow	Ready	Preview	Comment	Nov 13, 2025 6:50pm
workbench-nitro-workflow	Ready	Preview	Comment	Nov 13, 2025 6:50pm
workbench-nuxt-workflow	Ready	Preview	Comment	Nov 13, 2025 6:50pm
workbench-sveltekit-workflow	Ready	Preview	Comment	Nov 13, 2025 6:50pm
workbench-vite-workflow	Ready	Preview	Comment	Nov 13, 2025 6:50pm
workflow-docs	Ready	Preview	Comment	Nov 13, 2025 6:50pm

VaguelySerious

Thanks for contributing! The code looks good to me overall and I like the change.

I ran unit tests on this PR and it looks like there might be some e2e test failures - could you take a look? Your commits don't trigger tests, but you can test e2e locally by running e2e tests in packages/core against e.g. the nextjs-turbopack workbench app running in dev mode. See the github tests.yml file on how that's set up.

Once tests are green, this would be good to merge

VaguelySerious · 2025-11-11T04:57:51Z

packages/world-local/src/config.test.ts

+  describe('edge cases', () => {
+    it('should handle empty config object', async () => {
+      const { getPort } = await import('@workflow/utils/get-port');
+      vi.mocked(getPort).mockResolvedValue(undefined);


Suggested change

vi.mocked(getPort).mockResolvedValue(undefined);

vi.mocked(getPort).mockResolvedValue({});

fixed the issue. it was overriding defaults with undefined. getPort returns undefined instead of an empty object

- Updated createEmbeddedWorld to filter out undefined values from args before merging with the default config. - This change ensures that only defined arguments are considered, enhancing the function's robustness. Signed-off-by: Saatvik Arya <aryasaatvik@gmail.com>

VaguelySerious · 2025-11-13T19:31:15Z

Looks great, thanks again!

adriandlam and others added 21 commits November 6, 2025 14:16

feat: add getPort method for detecting pid port

da210ba

lockfile

54b47f3

update tests and fix getPort usage

36c5cf2

changeset

20f009b

docs: update sveltekit getting started

b4a7604

fix: use pid-port

9d8d329

fix: not using config port env

54e4019

fix: remove unused getPort from world core

cab43ef

remove unused stuff

a914cd2

fix: world local config returning port 3000 as fallback

8eca292

changeset

c39e144

fix: rebase conflicts

93862a6

fix: util test missing http import

b706b52

changeset

6c2e7a2

fix: wrong import for getPort in core runtime

757fa0c

fix: getPort in @workflow/utils being imported into workflow runtime

62e1123

test: simplify sveltekit test

53d9038

fix missing import in test

5563d52

fix: async await stuff with getPort

9072175

feat(utils,core,world-local): add port detection and baseUrl support

27a12f4

docs: document port detection and baseUrl features

34039c3

aryasaatvik mentioned this pull request Nov 7, 2025

fix(world-local): add baseUrl support for HTTPS and custom hostnames #245

Closed

vercel bot reviewed Nov 7, 2025

View reviewed changes

packages/core/src/util.test.ts Outdated Show resolved Hide resolved

test(world-local,utils,core): add comprehensive tests for port detect…

aead6c9

…ion and config Signed-off-by: Saatvik Arya <aryasaatvik@gmail.com>

Merge branch 'main' into feat/world-local-config

6c377ff

aryasaatvik force-pushed the feat/world-local-config branch from 57fbd63 to 6c377ff Compare November 8, 2025 19:44

aryasaatvik changed the title ~~feat(world-local): add port detection and baseUrl support~~ feat(world-local): add baseUrl config and improve port handling Nov 8, 2025

vercel bot reviewed Nov 8, 2025

View reviewed changes

packages/world-local/src/config.ts Outdated Show resolved Hide resolved

aryasaatvik added 4 commits November 9, 2025 01:37

chore: update changeset to major for breaking API change

2c75931

The createEmbeddedWorld API signature change is breaking: - Before: createEmbeddedWorld(dataDir?, port?) - After: createEmbeddedWorld(args?: Partial<Config>) Signed-off-by: Saatvik Arya <aryasaatvik@gmail.com>

chore: remove bug fixes section from changeset

2e363cb

These were bugs introduced and fixed within the same PR, not pre-existing bugs, so they shouldn't be listed as fixes. Signed-off-by: Saatvik Arya <aryasaatvik@gmail.com>

chore: remove auto port detection from new features

2397c01

Automatic port detection already existed in main via getPort(). This PR only adds baseUrl config and port 0 support. Signed-off-by: Saatvik Arya <aryasaatvik@gmail.com>

vercel bot deployed to Preview – workbench-vite-workflow November 11, 2025 05:00 View deployment

vercel bot deployed to Preview – workbench-sveltekit-workflow November 11, 2025 05:00 View deployment

vercel bot deployed to Preview – example-nextjs-workflow-webpack November 11, 2025 05:01 View deployment

vercel bot deployed to Preview – workbench-nitro-workflow November 11, 2025 05:01 View deployment

vercel bot deployed to Preview – example-workflow November 11, 2025 05:01 View deployment

vercel bot deployed to Preview – example-nextjs-workflow-turbopack November 11, 2025 05:01 View deployment

vercel bot deployed to Preview – workbench-nuxt-workflow November 11, 2025 05:01 View deployment

vercel bot deployed to Preview – workflow-docs November 11, 2025 05:02 View deployment

VaguelySerious reviewed Nov 11, 2025

View reviewed changes

vercel bot deployed to Preview – workbench-vite-workflow November 13, 2025 18:49 View deployment

vercel bot deployed to Preview – workbench-hono-workflow November 13, 2025 18:50 View deployment

vercel bot deployed to Preview – workbench-nuxt-workflow November 13, 2025 18:50 View deployment

vercel bot deployed to Preview – example-nextjs-workflow-webpack November 13, 2025 18:50 View deployment

vercel bot deployed to Preview – workbench-sveltekit-workflow November 13, 2025 18:50 View deployment

vercel bot deployed to Preview – workbench-nitro-workflow November 13, 2025 18:50 View deployment

vercel bot deployed to Preview – example-workflow November 13, 2025 18:50 View deployment

vercel bot deployed to Preview – example-nextjs-workflow-turbopack November 13, 2025 18:50 View deployment

vercel bot deployed to Preview – workflow-docs November 13, 2025 18:50 View deployment

VaguelySerious approved these changes Nov 13, 2025

View reviewed changes

VaguelySerious merged commit aa015af into vercel:main Nov 13, 2025
26 of 35 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(world-local): add baseUrl config and improve port handling #260

feat(world-local): add baseUrl config and improve port handling #260

aryasaatvik commented Nov 7, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Nov 7, 2025 •

edited

Loading

Uh oh!

vercel bot commented Nov 7, 2025

Uh oh!

Uh oh!

pranaygp commented Nov 8, 2025

Uh oh!

Uh oh!

vercel bot commented Nov 11, 2025 •

edited

Loading

Uh oh!

VaguelySerious left a comment

Uh oh!

VaguelySerious Nov 11, 2025

Uh oh!

aryasaatvik Nov 13, 2025

Uh oh!

Uh oh!

VaguelySerious commented Nov 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	vi.mocked(getPort).mockResolvedValue(undefined);
	vi.mocked(getPort).mockResolvedValue({});

feat(world-local): add baseUrl config and improve port handling #260

feat(world-local): add baseUrl config and improve port handling #260

Conversation

aryasaatvik commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add baseUrl configuration and improve port handling

Key Features

Breaking Changes

Uh oh!

changeset-bot bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Nov 7, 2025

Uh oh!

Uh oh!

pranaygp commented Nov 8, 2025

Uh oh!

Uh oh!

vercel bot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VaguelySerious left a comment

Choose a reason for hiding this comment

Uh oh!

VaguelySerious Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

aryasaatvik Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

VaguelySerious commented Nov 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aryasaatvik commented Nov 7, 2025 •

edited

Loading

changeset-bot bot commented Nov 7, 2025 •

edited

Loading

vercel bot commented Nov 11, 2025 •

edited

Loading