-
Notifications
You must be signed in to change notification settings - Fork 94
Remove step function transformation in client mode #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove step function transformation in client mode #271
Conversation
🦋 Changeset detectedLatest commit: f19e847 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
794c701 to
09b346c
Compare
09b346c to
f19e847
Compare
VaguelySerious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I see the API endpoint isn't being added to to Hono / Nitro v1/v2, but I guess that's fine since we don't run e2e tests against them yet
The SWC compiler was transforming step functions in client mode to call
runStep(), a stubbed function that throws errors. This prevented direct step function calls outside workflows, contradicting the documented behavior.Changes
SWC transform (
packages/swc-plugin-workflow/transform/src/lib.rs)TransformMode::Clientnow only have their directive removed, preserving the original function bodyrunStepFixture tests
output-client.jsfiles viaUPDATE=1to reflect unchanged step implementationsNew E2E test
Before
After
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.