Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capitalise name of logged in user in header #752

Closed
ayusharma opened this issue Jun 12, 2018 · 7 comments · Fixed by #812
Closed

Capitalise name of logged in user in header #752

ayusharma opened this issue Jun 12, 2018 · 7 comments · Fixed by #812
Assignees
@priscilawebdev
Labels
good first issue outdated PR-Welcome React
Milestone
3.x

Comments

@ayusharma
Copy link
Member

Is your feature request related to a problem? Please describe.
currently, the name is in lowercase.

Describe the solution you'd like
The name can be capitalised. eg. Ayush Sharma

Describe alternatives you've considered
Not required.
screen shot 2018-06-12 at 19 37 00

Additional context
Not required.
@juanpicado juanpicado added this to the 3.x.x milestone Jun 12, 2018
@chriscoderdr
Copy link

I'll take this one if is not already taken :)

@juanpicado
Copy link
Member

All yours , go ahead :-)

@priscilawebdev priscilawebdev self-assigned this Jun 16, 2018
@ayusharma ayusharma mentioned this issue Jul 10, 2018
Merged
ayusharma added a commit to ayusharma/verdaccio that referenced this issue Jul 11, 2018
@ayusharma
feat: capitalises logged in user name (verdaccio#752)
26864c5
ayusharma added a commit to ayusharma/verdaccio that referenced this issue Jul 11, 2018
@ayusharma
feat: capitalises logged in username (verdaccio#752)
0e21e35
@juanpicado
Copy link
Member

@ayusharma @priscilawebdev I think you both worked on the same ticket. Sorry about that. @ayusharma PR was merge early this week :(

@priscilawebdev priscilawebdev mentioned this issue Jul 14, 2018
Closed
@priscilawebdev
Copy link
Contributor

priscilawebdev commented Jul 14, 2018 •
edited
Loading

@ayusharma @juanpicado It was still open, so I took it..but fine :)

@juanpicado
Copy link
Member

Thanks for your effort @priscilawebdev

@ayusharma
Copy link
Member Author

@priscilawebdev Sorry for the misunderstanding. :(

paulbrimicombe pushed a commit to paulbrimicombe/verdaccio that referenced this issue Jul 27, 2018
@ayusharma @paulbrimicombe
feat: capitalises logged in username (verdaccio#752)
d7ab55d
@lock
Copy link

lock bot commented Jan 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Jan 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@priscilawebdev priscilawebdev

Labels
good first issue outdated PR-Welcome React
Projects
None yet
Milestone
3.x
Development

Successfully merging a pull request may close this issue.

feat: capitalises logged in user name ayusharma/verdaccio
4 participants
@juanpicado @chriscoderdr @ayusharma @priscilawebdev