Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible data loss upstream #306

Merged
merged 8 commits into from
Aug 27, 2017
Merged

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented Aug 25, 2017

Type: feature

Description:
Author: @Meeeeow
Follow up of #300

  • Throw error when the error code is not ENOENT during reading package database file to prevent possible data loss
  • Add warning about PM2 cluster mode to docs
  • new: Add unit test for locking feature

Result

If for any reason the database is corrupted, the user will see that message. It won't be able to publish packages.

➜ npm publish                                 
npm ERR! publish Failed PUT 422
npm ERR! code E422
npm ERR! Verdaccio database is locked, please contact your administrator to checkout logs during verdaccio startup. : npm-test-hello-world

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/user/.npm/_logs/2017-08-25T18_24_48_546Z-debug.log

Resolves #??? ==> @Meeeeow could you fill this part?

@juanpicado juanpicado force-pushed the fix_possible_data_loss_upstream branch from 1354dee to 04710d8 Compare August 26, 2017 05:45
@juanpicado juanpicado requested a review from AvailCat August 26, 2017 05:46
@AvailCat AvailCat merged commit dd623dc into master Aug 27, 2017
@AvailCat AvailCat deleted the fix_possible_data_loss_upstream branch September 17, 2017 12:35
@lock
Copy link

lock bot commented May 30, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants