Removed Less-Simple Uses of STD Iterator #2561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also remove a strange alias used called "my_iter" which, according to the comment, was used to avoid potential ambiguity in the Clang compiler. I am not sure what this means, but I think it should be less ambiguous when we no longer inheret from std::iterator.
This also remove a strange alias used called "my_iter" which, according to the comment, was used to avoid potential ambiguity in the Clang compiler. I am not sure what this means, but I think it should be less ambiguous when we no longer inheret from std::iterator.
AlexandreSinger
force-pushed
the
feature-remove-std-iterator
branch
from
1a649e0 to
63d57e7
Compare
|
@vaughnbetz This has passed CI, I have verified that the warnings for these uses of std::iterator are now gone. These are all of the uses of std::iterator that VTR is responsible for. The rest of the uses can be resolved by upgrading capnproto and Yosys. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #2557 for context.
As with PR #2558 , removed slightly more complicated uses of std::iterator after discussing this more.
This PR modifies Tatum, I will upstream these changes back to the Tatum library after the PR is merged.
After this PR, the only use of std::iterator would be in the Capnproto library, which may be quite a bit more complicated to resolve.