-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/migrate androidx #683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for these changes, but need some confirmation for my question.
@@ -70,4 +72,8 @@ ext { | |||
powermockXstream : "org.powermock:powermock-classloading-xstream:${powermockVersion}", | |||
espresso : "com.android.support.test.espresso:espresso-core:${espressoVersion}", | |||
] | |||
|
|||
localizationLibraries = [ | |||
localization: "com.akexorcist:localization:${localizationVersion}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried this lib? Or at least confirming that the issue isn't happening on the SDK itself or affecting the host app. I'm seeing some open issue may become critical if affecting our merchant's app :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we have tested it. and also the merchant have tested that our sdk using that lib. and if I use release build it's still running well. but let re-test by QA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@farhanpahlevi @askur87 Feel free to ask for help when you have any critical problem from my library in your SDK. Open issue in my repository or send an email is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks @akexorcist. will let you know if we facing some issue with your library.
@@ -7,7 +7,7 @@ | |||
android:layout_height="match_parent" | |||
android:orientation="vertical"> | |||
|
|||
<android.support.design.widget.TabLayout | |||
<com.google.android.material.tabs.TabLayout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the past, this component causing an issue when host app using a different android library with mid-SDK, let say mid-SDK use AndroidX & host-app using legacy android support, vice versa. Can you confirm it not making any crash issu?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if our SDK using AndoidX it will be required for HostApp to migrate to Android as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.