Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/migrate androidx #683

Merged
merged 13 commits into from
Jan 18, 2021
Merged

Feature/migrate androidx #683

merged 13 commits into from
Jan 18, 2021

Conversation

askur87
Copy link
Collaborator

@askur87 askur87 commented Jan 14, 2021

No description provided.

Copy link
Contributor

@farhanpahlevi farhanpahlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for these changes, but need some confirmation for my question.

@@ -70,4 +72,8 @@ ext {
powermockXstream : "org.powermock:powermock-classloading-xstream:${powermockVersion}",
espresso : "com.android.support.test.espresso:espresso-core:${espressoVersion}",
]

localizationLibraries = [
localization: "com.akexorcist:localization:${localizationVersion}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried this lib? Or at least confirming that the issue isn't happening on the SDK itself or affecting the host app. I'm seeing some open issue may become critical if affecting our merchant's app :

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we have tested it. and also the merchant have tested that our sdk using that lib. and if I use release build it's still running well. but let re-test by QA.

Copy link

@akexorcist akexorcist Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farhanpahlevi @askur87 Feel free to ask for help when you have any critical problem from my library in your SDK. Open issue in my repository or send an email is fine.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks @akexorcist. will let you know if we facing some issue with your library.

@@ -7,7 +7,7 @@
android:layout_height="match_parent"
android:orientation="vertical">

<android.support.design.widget.TabLayout
<com.google.android.material.tabs.TabLayout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the past, this component causing an issue when host app using a different android library with mid-SDK, let say mid-SDK use AndroidX & host-app using legacy android support, vice versa. Can you confirm it not making any crash issu?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if our SDK using AndoidX it will be required for HostApp to migrate to Android as well.

Copy link
Contributor

@theanh0512 theanh0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@askur87 askur87 merged commit 2f9f0aa into develop Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants