Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoplaying video not loaded correctly after entering the viewport #240

Closed
maeligg opened this issue Aug 27, 2018 · 2 comments
Closed

Autoplaying video not loaded correctly after entering the viewport #240

maeligg opened this issue Aug 27, 2018 · 2 comments

Comments

@maeligg
Copy link
Contributor

maeligg commented Aug 27, 2018 •
edited
Loading

Hello,

Testing on V10.15.0 + Chrome latest.
I think this is a separate issue from #239 so I'm opening a new one. It looks like when you are using 'data-src' on <source> instead of <video>, the autoplayed video is not loaded correctly. Looking at https://developers.google.com/web/fundamentals/performance/lazy-loading-guidance/images-and-video/#for_video_acting_as_an_animated_gif_replacement it seems that you need to manually call the element's load() method after updating the src.
@maeligg maeligg changed the title Video not loaded correctly after Autoplaying video not loaded correctly after entering the viewport Aug 27, 2018
@maeligg maeligg mentioned this issue Aug 27, 2018
Merged
@verlok
Copy link
Owner

verlok commented Aug 30, 2018

Fixed in v.10, not yet in v.8

@verlok
Copy link
Owner

verlok commented Aug 30, 2018

Fixed in v.8 too

@verlok verlok closed this as completed Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@verlok @maeligg