Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class "loaded" not applied to a loaded video #239

Closed
maeligg opened this issue Aug 27, 2018 · 4 comments
Closed

Class "loaded" not applied to a loaded video #239

maeligg opened this issue Aug 27, 2018 · 4 comments

Comments

@maeligg
Copy link
Contributor

maeligg commented Aug 27, 2018

Hello,

I am using V10.15.0 of lazyload, testing on the latest version of Chrome.
Lazy loading a <video> seems to work fine except that the "loaded" class is never applied to it ("loading" is correctly applied).
Before entering the viewport :
<video width="100%" autoplay="" loop="" muted="" data-src="my-video" class="js-lazyload"</video>
After entering the viewport :
<video width="100%" autoplay="" loop="" muted="" data-src="assets/my-video.mp4" class="js-lazyload loading" src="my-video.mp4" data-was-processed="true"></video>

@verlok
Copy link
Owner

verlok commented Aug 30, 2018

Need to listen to the loadeddata event.

@verlok
Copy link
Owner

verlok commented Aug 30, 2018

Note to self: possibly add audio to the lazy-loadable HTML elements.

verlok pushed a commit that referenced this issue Aug 31, 2018
@verlok verlok closed this as completed in 3a95e17 Aug 31, 2018
@verlok verlok reopened this Aug 31, 2018
@verlok
Copy link
Owner

verlok commented Aug 31, 2018

Must release the fix on version 8.x too.

verlok added a commit that referenced this issue Sep 2, 2018
@verlok
Copy link
Owner

verlok commented Sep 2, 2018

Solved in both versions 8.15.2 and 10.16.2

@verlok verlok closed this as completed Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants