Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken SSR build #287

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Fix broken SSR build #287

merged 1 commit into from
Jan 31, 2019

Conversation

AlexCSR
Copy link
Contributor

@AlexCSR AlexCSR commented Dec 25, 2018

I'm using this package with React + SSR and I've got a navigator is undefined error while building server bundle. After try to fix it, I've got another error about document is undefined which caused by default settings object container value.

@goranefbl
Copy link

same here, is this going into production?

@verlok verlok merged commit d1df428 into verlok:master Jan 31, 2019
@verlok
Copy link
Owner

verlok commented Jan 31, 2019

Good one, thanks @AlexCSR!
And Merry Christmas (I saw your commit was made day December 25th).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexCSR @goranefbl @verlok