Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid DOM operation if applying an empty className #606

Conversation

stanleyxu2005
Copy link

A new PR followed by #605

Description see here #605 (comment)
The PR includes file changes in the dist folder

@stanleyxu2005 stanleyxu2005 changed the title Ignore applying empty className Avoid DOM operation if applying an empty className Mar 17, 2024
@verlok
Copy link
Owner

verlok commented Mar 19, 2024

Hey, thank you again, but GitHub still says you want to merge from your branch to verlok/master.
Apparently I'm not able to use GitHub properly, I'll need to see how to protect the main branch from PR commits.
Anyway I'll apply your changes and mention you both in the commit message and in the changelog.
I hope you're fine with that.

@stanleyxu2005
Copy link
Author

stanleyxu2005 commented Mar 19, 2024

Hey, thank you again, but GitHub still says you want to merge from your branch to verlok/master. Apparently I'm not able to use GitHub properly, I'll need to see how to protect the main branch from PR commits. Anyway I'll apply your changes and mention you both in the commit message and in the changelog. I hope you're fine with that.

Oh yea. Please go ahead with the merge. I'm fine with that @verlok Cheers

@verlok
Copy link
Owner

verlok commented Mar 19, 2024

I just noticed there's a data attribute being added to the elements observed by this library anyway, even if the class name is not added anymore

@stanleyxu2005
Copy link
Author

I just noticed there's a data attribute being added to the elements observed by this library anyway, even if the class name is not added anymore

Could you point it out, what data attribute?

@verlok
Copy link
Owner

verlok commented Mar 19, 2024

Could you point it out, what data attribute?

The attribute name is data-ll-status
It becomes loaded when it's an image and it's loaded.

@verlok
Copy link
Owner

verlok commented Mar 19, 2024

Released with version 17.9.0

@verlok verlok closed this Mar 19, 2024
@stanleyxu2005 stanleyxu2005 deleted the feature/avoid-class-add-remove-if-not-necessary branch March 27, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants