Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (protoc-gen-twirpy): service url is not compatible with golang server #18

Closed
wants to merge 1 commit into from

Conversation

khevse
Copy link

@khevse khevse commented May 29, 2020

twirp does't use original service name from protobuf:
https://github.com/twitchtv/twirp/blob/master/protoc-gen-twirp_python/main.go#L142
But it's in a private package. So I created a compatible version.

@ofpiyush
Copy link
Contributor

Thanks for the PR @khevse! Sorry for the late response, I'd accidentally unwatched this repo.

I did not know that they change the names in the URL.

After learning about this, I checked their go generator code as that one seems to be better maintained.

They apparently do it for methods as well.

I'll try to figure out their stance on this and see if we can get this added in the spec for clarity and maybe have the CamelCase method part of a public API.

Meanwhile, could you add the variant to the method name as well in this PR?

@ofpiyush
Copy link
Contributor

Version 7 of twirp fixed this issue.

Thank you for bringing it up @khevse

@ofpiyush ofpiyush closed this Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants