Run-time deprecation warning for native Windows, 32-bit systems, ParFORM and Checkpoint #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tueda
force-pushed
the
runtime-deprecation-warning
branch
from
66a0e6f to
7d40204
Compare
|
A run-time message seems good, as you say users may just use the distributed binaries rather than compiling themselves. This would be the first "--" option, is it more consistent to use a single "-" like |
|
I was considering the convention for long-name options in GNU tools (other than GCC), but this makes sense ( If you have a better name than |
tueda
force-pushed
the
runtime-deprecation-warning
branch
from
7d40204 to
eb3658c
Compare
tueda
force-pushed
the
runtime-deprecation-warning
branch
from
eb3658c to
27ece86
Compare
tueda
force-pushed
the
runtime-deprecation-warning
branch
from
27ece86 to
dbbf3bc
Compare
tueda
changed the title
|
Added a deprecation warning for the checkpoint as well, as discussed during the video call. Though it says we are considering the deprecation of the checkpoint mechanism, I maintained the checkpoint code for the deprecation warning flag. |
FORM prints deprecation warnings at startup for native Windows, 32-bit (ILP32) and ParFORM (MPI) versions, as well as for the use of the checkpoint mechanism. This encourages users who need support for these deprecated features to leave a comment on the corresponding GitHub issues. The warnings can be suppressed by using the -ignore-deprecation command-line option or by setting the environment variable FORM_IGNORE_DEPRECATION=1.
tueda
force-pushed
the
runtime-deprecation-warning
branch
from
dbbf3bc to
33a8f45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of deprecation messages like those in #475 (comment) but at runtime startup rather than at build time, for Windows, 32bit builds and ParFORM.
End users may not build binaries themselves. 32-bit binaries and ParFORM are distributed by various distributors. We can distribute native Windows binaries if #511 is merged and
Delete Windows binariesindeploy.ymlis removed. This patch will cause these end users to see annoying deprecation warnings.The deprecation warning looks like, for example, for ParFORM:
This warning can be suppressed by the (undocumented)
--ignore-deprecationoption or the environment variableFORM_IGNORE_DEPRECATION=1.TODO: we need 3 separate issues for users to leave comments regarding the deprecation.