Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip navs without type in EPUB 3 navigation documents #119

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

vers-one
Copy link
Owner

Skip navs without type in EPUB 3 navigation documents

This is:

  • a bug fix
  • an enhancement

Related issue: #116

Description

This pull request changes Epub3NavDocumentReader to make it skip nav elements without the epub:type attribute in EPUB 3 navigation documents.

Testing steps

Use the example nav section from the linked issue. After the change is applied, the code should not throw the Epub3NavException.

@vers-one vers-one self-assigned this Dec 16, 2024
@vers-one vers-one linked an issue Dec 16, 2024 that may be closed by this pull request
@vers-one vers-one merged commit 3bc152b into master Dec 16, 2024
4 checks passed
@vers-one vers-one deleted the non-epub-navs branch December 16, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nav Parsing is too strict
1 participant