[FIX] purchase_advance_payment: tests currency #5
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 16.0-versada #5 +/- ##
===============================================
Coverage ? 96.76%
===============================================
Files ? 313
Lines ? 6054
Branches ? 691
===============================================
Hits ? 5858
Misses ? 95
Partials ? 101 ☔ View full report in Codecov by Sentry. |
| @@ -146,6 +146,8 @@ def setUpClass(cls): | |||
| "currency_id": cls.currency_usd.id, | |||
| } | |||
| ) | |||
| if cls.purchase_order_1.currency_id == cls.purchase_order_1.company_id.currency_id: | |||
| cls.purchase_order_1.currency_id = cls.currency_usd | |||
There was a problem hiding this comment.
Shouldn't we then always force USD currency? Or it will not work correctly with EUR then? Also would be nice to have a comment explaining why this is needed.
Either way, check seems strange. Maybe just check what kind of currency company currency is and decide. Why order currency must match company currency to switch to usd?..
There was a problem hiding this comment.
By the way, can you enable pre-commit on this submodule and run it, so it would fix code according to OCA guidelines.
There was a problem hiding this comment.
Before our change, company and order already had different currencies. And these tests only works when currencies are different.
Add cehck to make sure that order and company have different currencies. https://hive.versada.eu/projects/devops/work_packages/19186
AurelijaNorvaisaite
force-pushed
the
fix-tests-wkf-flexible-test-scopes-avi
branch
from
590870b to
2b2b75e
Compare
Add check to make sure that order and company have different currencies.
https://hive.versada.eu/projects/devops/work_packages/19186