17.0 mig purchase advance payment #6
Conversation
Currently translated at 100.0% (229 of 229 strings) Translation: purchase-workflow-17.0/purchase-workflow-17.0-purchase_request Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_request/it/
…ments in PO residual amount.
| @@ -449,4 +448,4 @@ <h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2> | |||
| </div> | |||
| </div> | |||
| </body> | |||
| </html> | |||
| </html> | |||
There was a problem hiding this comment.
Looks like you are removing newline. Should fix your editor to not mess up file endings:)
There was a problem hiding this comment.
This was pre-commit fix I think.
There was a problem hiding this comment.
Hm, if its done by pre-commit, it looks like its doing something wrong. Usually it should do the opposite, cause now github is throwing "warning":)
There was a problem hiding this comment.
Yep, looks like it was editor not pre-commit after all...
| "rate": 1.20, | ||
| "currency_id": cls.currency_usd.id, | ||
| "inverse_company_rate": 1.20, | ||
| "currency_id": cls.currency_euro.id, |
There was a problem hiding this comment.
Is this really gonna help? Thing with tests that involve company currency or related is tricky for main company. Cause some modules can replace the currency, but if some other modules are installed it can change it to another. So you end up with either USD or EUR currency (but it is not consistent). This can fail if other case happens. Unless you are sure here we will always have EUR?
There was a problem hiding this comment.
Well, all previous tests are made assuming, that USD is base currency. My only change was made to fix the failing tests so that rate is created for EUR currency and not USD. Which did not make any sense, honestly I don't know why it worked prior to v17.
There was a problem hiding this comment.
As I said, depending what module is installed, it can have different currency. So there are cases when company currency is different and then tests become inconsistent. For example tests when different COA (localization) is installed:). Better approach would be to test on fresh company, where we would not need to rely on set data that cant even be changed. Though for now, lets hope this won't blow up randomly, which is the most annoying failure:)
There was a problem hiding this comment.
I agree. Although since this is an OCA module, I'm surprised it didn't blow up in previous versions...
maciej-wichowski
force-pushed
the
17.0-mig-purchase_advance_payment
branch
from
aa29ba8 to
93cf953
Compare
No description provided.