Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display_name does not allow multibyte symbols #13

Closed
ibc opened this issue Nov 12, 2012 · 1 comment
Closed

display_name does not allow multibyte symbols #13

ibc opened this issue Nov 12, 2012 · 1 comment
Assignees
@jmillan
Labels
API enhancement JavaScript

Comments

@ibc
Copy link
Member

ibc commented Nov 12, 2012

Setting 'dispplay_uri' = ' Iñaki' fails, it requires using `'display_name' = '"Iñaki"' which is ugly. JsSIP should be clever enough to allow any kind of string as display_name value, and then ALWAYS enclose it between double quotes (regardless they are needed or not).

Prior to fix this bug, fixing #12 is required.
@ghost ghost assigned jmillan Nov 12, 2012
@ibc ibc closed this as completed Nov 12, 2012
@ibc ibc reopened this Nov 12, 2012
@ibc
Copy link
Member Author

ibc commented Nov 12, 2012

Fixed in aa51291

@ibc ibc closed this as completed Nov 12, 2012
ibc added a commit that referenced this issue Nov 12, 2012
@ibc
Fixes #13. Adds double quotes to the user given display_name value be…
aa51291 
…fore checking it

(allows multibyte symbols).
@ibc ibc modified the milestone: Version 0.2.1 Jan 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmillan jmillan

Labels
API enhancement JavaScript
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibc @jmillan