Improve typings for event emitters #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unao
force-pushed
the
typed-event-emitters
branch
from
75e7b86
to
2785898
Compare
|
Will review soon, sorry for the delay. |
…DataProducer, DataConsumer
unao
force-pushed
the
typed-event-emitters
branch
from
2785898
to
ebac282
Compare
|
@ibc sure no hurry ;) |
|
We don't forget about this. It's just that we are too busy. |
|
I probably will close this PR soon and just fork this repo to move forward. |
|
Please don't. Will manage this PR this week. Promise. |
ibc
requested changes
Jun 18, 2022
| @@ -148,9 +149,41 @@ export type PlainRtpParameters = | |||
| port: number; | |||
| }; | |||
|
|
|||
| export type TransportProduceParameters<AppData = unknown> = | |||
There was a problem hiding this comment.
AppData default value should not be unkown but Record<string, unknown> (everywhere).
|
@unao I've made some changes that improve |
|
Closed in favour of #209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a logical continuation of versatica/mediasoup#764 would like to add analogous types for mediasoup client.
I introduced some implicit assumption around
safeEmitAsPromise: if corresponding type is not specified it allows to pass any arguments otherwise it must be a single argument conforming to the first declared type.There is still some room left for improvements around
AppData(for preventing unsafe cast) - if you were interested I could add it once this is merged in.