a jest testing poc #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this is definitely a must. We need test units in mediasoup-client. Said that, it's important to test the mediasoup-client surface API, but it's even more important to test that the underlying stuff (per-browser specific handlers) do work as expected. Let's discuss about this next week with tons of beers. |
|
Hi, we are planning and defining mediasoup v3. In both, client and server sides, v3 will expose a much more granular API that will make it possible to add more test units as those you propose here. Will come back to this once v3 is done. |
|
Hey, I've added So thanks very useful :) |
|
Great thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi friends
I've tried to do some basic tests for mediasoup-client, it can be challenging and fun because of the way it's architected.
Probably this PR is not good enough for merging, I might even break something as I needed to mess with deps, but I wanted to show what I tried and this serves as PR++ for Hacktoberfest even if not accepted. Perhaps it can help as reference if adding unit tests is scoped in the future.
Thank you and happy Hacktoberfest :)