Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation about required dependencies and extra workarounds on Windows #37

Merged
merged 2 commits into from
Oct 24, 2021

Conversation

nazar-pc
Copy link
Contributor

I danced around various issues and compiled what is required on Windows 10 with Visual Studio 2019 Community Edition for mediasoup to work.

Instructions for environment setup are given both for Command Prompt and PowerShell just in case.

Complements versatica/mediasoup#692. We might make everything just "automagically" work on Windows if we:

  • pull environment setup somehow into Makefile instead of requiring manual setup
  • migrate from Makefile to Python script to remove MinGW requirement

But I will leave those for someone else.

Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Just some dots missing

* In Debian and Ubuntu install the `build-essential` DEB package. It includes both `make` and `gcc`/`g++`.
* In YUM based Linux (Red Hat, CentOS) use `yum groupinstall "Development Tools"`.
* On Debian and Ubuntu install the `python3-pip` DEB package, otherwise PIP package manager might be unavailable.
* On Debian and Ubuntu install the `build-essential` DEB package. It includes both `make` and `gcc`/`g++`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make dependency has been removed above, does this sentence make sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just moved to the common dependencies, alongside Node.js and Python.

documentation/v3/mediasoup/installation.md Outdated Show resolved Hide resolved
documentation/v3/mediasoup/installation.md Outdated Show resolved Hide resolved
documentation/v3/mediasoup/installation.md Outdated Show resolved Hide resolved
documentation/v3/mediasoup/installation.md Outdated Show resolved Hide resolved
documentation/v3/mediasoup/installation.md Outdated Show resolved Hide resolved
@ibc
Copy link
Member

ibc commented Oct 24, 2021

So approved again

@nazar-pc
Copy link
Contributor Author

I have no rights to merge here either way, so feel free to go ahead, it doesn't depend on mediasoup PR in any way, it is purely complementary.

@ibc
Copy link
Member

ibc commented Oct 24, 2021

Please remind me to give you access to this repo as well next week

@ibc ibc merged commit 4115f55 into versatica:master Oct 24, 2021
@nazar-pc nazar-pc deleted the updated-windows-instructions branch October 24, 2021 23:20
@nazar-pc
Copy link
Contributor Author

Can you deploy these updates to the website, please?

@ibc
Copy link
Member

ibc commented Oct 28, 2021

I'll do in less than an hour. Do we need a mediasoup release for this docs to make sense? I'll do one anyway.

@nazar-pc
Copy link
Contributor Author

No, release is not necessary. Mediasoup fixes were on top of the PR that wasn't released yet, so everything is fine.

@ibc
Copy link
Member

ibc commented Oct 28, 2021

website published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants