Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new changes/additions in mediasoup v3 done within flatbuffers branch #50

Merged
merged 6 commits into from
Nov 8, 2023

Conversation

ibc
Copy link
Member

@ibc ibc commented Oct 31, 2023

@ibc ibc mentioned this pull request Oct 31, 2023
7 tasks
@piranna
Copy link

piranna commented Oct 31, 2023

It looks like a lot of changes... Will there be documentation of the in-wire serialized format fields?

@ibc
Copy link
Member Author

ibc commented Oct 31, 2023

What is in-wire serialization format? You mean flatbuffer message formats? If so those are in worker/fbs folder and we won't document them anywhere else because the my are private types between Node/Rust and worker.

@piranna
Copy link

piranna commented Oct 31, 2023

What is in-wire serialization format? You mean flatbuffer message formats? If so those are in worker/fbs folder and we won't document them anywhere else because the my are private types between Node/Rust and worker.

Yes, I was talking about that. I know it's an implementation detail, was curious to know how they were.

@ibc
Copy link
Member Author

ibc commented Oct 31, 2023

@jmillan this is ready, so once we merge flatbuffers in v3 and release a new version. we must merge this PR and re-publish the website.

@ibc ibc merged commit a9a52a2 into master Nov 8, 2023
@ibc ibc deleted the flatbuffers-docs branch November 8, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants