[usrsctp] Use usrsctp_get_timeout() when available #1011
Comments
ibc
added a commit
that referenced
this issue
Mar 5, 2024
### Details - Related task: #1011. Note that usrsctp author never cared about the existing PR so we are on our own. - So I've forked usrctp, added the `usrsctp_get_timeout()` feature and released version 0.9.6.0: versatica/usrsctp#1 - And I've made `usrsctp.wrap` point to it. ### Notes - It would be great to have a way to pass `sctp_debug=true` when building usrsctp Meson subproject so it defines `SCTP_DEBUG` (needed in `DepUsrSCTP.cpp` to show SCTP debug). An manual alternative is to edit `meson.build` of usrsctp and add it unconditionally. - I'm calling `HandleUsrSctpTimers()` everytime the timer fires (of course), also in `onSendSctpData` callback and also when SCTP data is received (in `SctpAssociation::ProcessSctpData()`. Not sure if correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a PR in usrsctp project adding a proper
usrsctp_get_timeout(), which is definitely missing in usrsctp for a proper single-thread usage.References:
usrsctp_get_timeout()function): single-thread API: add usrsctp_get_timeout() sctplab/usrsctp#349usrsctp_get_timeout(): Add usrsctp_get_timeout() sctplab/usrsctp#591usrsctp_get_timeout()in another project: https://github.com/frida/frida-core/blob/ab2581a0b7faea22d87a33c1cc6f2aab8bd88ece/lib/base/p2p-glue.c#L347Such a new PR sctplab/usrsctp#591 would make mediasoup way more efficient by using
usrsctp_get_timeout()rather than having a periodic timer checking usrsctp state every 10ms (seeCheckerclass inDepUsrSCTP.cpp). However, for this to happen we must promote that PR in usrsctp project so it gets merged and new version released.The text was updated successfully, but these errors were encountered: