[Bug] srtp will crash on 64 bit big-endian machine

[xia-chu]

Bug Report

Srtp will crash on 64 bit big-endian machine

Your environment

• Operating system: some 64 bit system
• Cpu: some big-endian machine

Issue description

These code my cause crash:

mediasoup/worker/src/RTC/SrtpSession.cpp

Line 164 in 73ec18a

srtp_protect(this->session, static_cast<void*>(EncryptBuffer), reinterpret_cast<int*>(len));

The len parameter is the type ofsize_t*, which on 64 bit environment, it is a 64 bit integer number。
But int usually will be 32 bit long, if we take address of 64 bit integer number as int * on big-endian machine,
we will take the address of its high 4 bytes。If srtp write vlaue 1024 to it, the vlaue of len will be 1024 << 32.

[ibc]

Thanks a lot. Will check and fix it in next days.

[ibc]

Thanks for the report. Would you mind taking a look to PR #637 (and test it if possible)?

[xia-chu]

Thank you very much, but I don't have a big-endian machine to test. I also received these feedback from others。
I don't think the previous code is perfect，i think this problem should be fixed.

[ibc]

Please, next time don't close the issue. Let's please close the issue (automatically) when the PR that solves it is merged.

[xia-chu]

ok thanks! 发自我的iPhone

…

------------------ Original ------------------ From: Iñaki Baz Castillo ***@***.***> Date: Mon,Aug 16,2021 9:46 PM To: versatica/mediasoup ***@***.***> Cc: 夏楚 ***@***.***>, State change ***@***.***> Subject: Re: [versatica/mediasoup] [Bug] srtp will crash on 64 bit big-endian machine (#636) Please, next time don't close the issue. Let's please close the issue (automatically) when the PR that solves it is merged. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.