Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate libsrtp wraparound with loss decryption failure #1438

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

ibc
Copy link
Member

@ibc ibc commented Aug 5, 2024

Fixes #1437

Details

  • Read the issue, please.
  • So solution is that SeqManager now includes a second constructor with initialOutput and we use it in all XxxxConsumer classes.

ibc added 2 commits August 5, 2024 18:37
Fixes #1437

### Details

- Read the issue, please.
- So solution is that `SeqManager` now includes a second constructor with `initialOutput` and we use it in all `XxxxConsumer` classes.
@ibc ibc requested review from jmillan and nazar-pc August 5, 2024 16:48
@ibc
Copy link
Member Author

ibc commented Aug 5, 2024

CC @fippo @lminiero

fippo added a commit to fippo/mediasoup that referenced this pull request Aug 6, 2024
fippo added a commit to fippo/mediasoup that referenced this pull request Aug 6, 2024
worker/src/RTC/PipeConsumer.cpp Outdated Show resolved Hide resolved
worker/include/RTC/SimpleConsumer.hpp Show resolved Hide resolved
ibc and others added 2 commits August 29, 2024 13:13
@ibc ibc merged commit d3a7ae8 into v3 Aug 29, 2024
39 of 51 checks passed
@ibc ibc deleted the fix-libsrtp-decryption-issue branch August 29, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

libsrtp: wraparound with loss decryption failure
2 participants