Fix io_uring support detection #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes #1435 ### Details - Having Kernel >= 6 doesn't guarantee that `io_uring` is enabled. Some systems disable it at kernel layer. - This PR checks if `io_uring` initialization works in launch time, otherwise `io_uring` is disabled. ### TODO - This is another story, but we should rename `WorkerSettings.disableLiburing` to `WorkerSettings.disableIoUring`. That's what we are disabling and not the `io_uring` C wrapper library called `liburing`.
nazar-pc
approved these changes
Aug 12, 2024
jmillan
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
io_uringis enabled. Some systems disable it at kernel layer.io_uringinitialization works in launch time, otherwiseio_uringis disabled.TODO
WorkerSettings.disableLiburingtoWorkerSettings.disableIoUring. That's what we are disabling and not theio_uringC wrapper library calledliburing.