fix(worker): cpu cores detection using sh and default to 4 #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case bash is missing from the system the `cpu_cores.sh` fails with an error and returns empty string resulting in command like `make -j BUILDTYPE=Release -C out` that uses unlimited jobs and could lead to signifficant CPU and RAM usage during build The cpu_cores.sh is now changed to using `sh` instead of `bash`, so it should be more portable. Additionally if the cpu detection fails the jobs default to 4, that should be safe enough.
|
Thanks, it makes sense. Released in mediasoup 3.4.1. |
smoke
deleted the
fix/worker-cpu-cores-detection-to-use-sh-so-it-is-portable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case bash is missing from the system the
cpu_cores.shfails with anerror and returns empty string resulting in command like
make -j BUILDTYPE=Release -C outthat uses unlimited jobs and couldlead to signifficant CPU and RAM usage during build
The cpu_cores.sh is now changed to using
shinstead ofbash, so itshould be more portable. Additionally if the cpu detection fails the
jobs default to 4, that should be safe enough.