Issue 357 workaround #388
Merged
Issue 357 workaround #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d issue: #357 - PortManager.cpp: Do not use `UV_UDP_RECVMMSG` in Windows due to a bug in libuv 1.37.0
jmillan
approved these changes
Apr 24, 2020
|
Clones removed
==============
+ worker/src/RTC/Transport.cpp -2
See the complete overview on Codacy |
|
Let's merge. Anyway we are not able to reproduce the crash so if something is still wrong people will report it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libwebrtc: Apply patch by @sspanak and @Ivaka to avoid crash. Related issue: Mediasoup worker crash (libwebrtc uint64_t/int64_t conversion related) #357. Patch done by @Ivaka and @sspanak.PortManager.cpp: Do not useUV_UDP_RECVMMSGin Windows due to a bug in libuv 1.37.0.