-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SeqManager.cpp: fix num discontinued bug and increase performance #396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test does not compile for me. It looks like you are not synced with v3
branch:
../test/src/RTC/TestSeqManager.cpp:409:15: error: use of class template 'TestSeqManagerInput' requires template
arguments
std::vector<TestSeqManagerInput> inputs =
Please take a look to the current All std::vector<TestSeqManagerInput<uint16_t>> inputs = However the diff in your PR does not include those templates. |
Also, I think |
Please add this and we are done. And let me know your name/URL or something to add into mediasoup Ackknowledges. |
Merged, thanks a lot! |
JunLong Zou |
Thanks, added here: https://mediasoup.org/about/#acknowledgements |
#395