Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeqManager.cpp: fix num discontinued bug and increase performance #396

Merged
merged 4 commits into from
May 11, 2020

Conversation

penguinol
Copy link
Contributor

Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test does not compile for me. It looks like you are not synced with v3 branch:

../test/src/RTC/TestSeqManager.cpp:409:15: error: use of class template 'TestSeqManagerInput' requires template
      arguments
                std::vector<TestSeqManagerInput> inputs =

@ibc
Copy link
Member

ibc commented May 11, 2020

Please take a look to the current TestSeqManager.cpp in mediasoup v3 branch:

All inputs are created with the proper template syntax:

std::vector<TestSeqManagerInput<uint16_t>> inputs =

However the diff in your PR does not include those templates.

@ibc
Copy link
Member

ibc commented May 11, 2020

Also, I think SeqMaanger.cpp should include #include <iterator> which exposes std::distance().

@ibc
Copy link
Member

ibc commented May 11, 2020

Also, I think SeqMaanger.cpp should include #include <iterator> which exposes std::distance().

Please add this and we are done. And let me know your name/URL or something to add into mediasoup Ackknowledges.

@ibc ibc merged commit 2a0f14b into versatica:v3 May 11, 2020
@ibc
Copy link
Member

ibc commented May 11, 2020

Merged, thanks a lot!

@ibc ibc changed the title fix secquence num discontiued problem and increase performance of seq… SeqManager.cpp: fix num discontinued bug and increase performance May 11, 2020
@penguinol
Copy link
Contributor Author

Also, I think SeqMaanger.cpp should include #include <iterator> which exposes std::distance().

Please add this and we are done. And let me know your name/URL or something to add into mediasoup Ackknowledges.

JunLong Zou
www.lonny.me

@ibc
Copy link
Member

ibc commented May 17, 2020

Thanks, added here: https://mediasoup.org/about/#acknowledgements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants