-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataChannel termination via the new DirectTransport #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmillan
approved these changes
May 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
masterpiece 👍
Co-authored-by: José Luis Millán <jmillan@aliax.net>
Co-authored-by: José Luis Millán <jmillan@aliax.net>
Co-authored-by: José Luis Millán <jmillan@aliax.net>
Co-authored-by: José Luis Millán <jmillan@aliax.net>
Co-authored-by: José Luis Millán <jmillan@aliax.net>
…oup into datachannel-termination
jmillan
reviewed
May 29, 2020
jmillan
reviewed
May 29, 2020
Here is an overview of what got changed by this pull request: Clones added
============
- worker/src/RTC/DataConsumer.cpp 1
- test/test-PlainTransport.js 6
- worker/src/RTC/DataProducer.cpp 1
- worker/include/Channel/UnixStreamSocket.hpp 2
- lib/PayloadChannel.js 5
- worker/include/RTC/DataConsumer.hpp 1
- worker/src/Channel/UnixStreamSocket.cpp 4
- lib/Router.js 1
- worker/include/RTC/WebRtcTransport.hpp 3
- lib/DirectTransport.js 1
- worker/src/PayloadChannel/UnixStreamSocket.cpp 4
- test/test-node-sctp.js 1
- worker/include/RTC/DirectTransport.hpp 3
- test/test-DataConsumer.js 1
- worker/include/RTC/PlainTransport.hpp 2
- test/test-DirectTransport.js 15
- worker/include/RTC/DataProducer.hpp 1
- worker/include/RTC/PipeTransport.hpp 2
- worker/include/PayloadChannel/UnixStreamSocket.hpp 2
- lib/Channel.js 4
- test/test-WebRtcTransport.js 3
Clones removed
==============
+ test/test-PipeTransport.js -1
See the complete overview on Codacy |
ibc
changed the title
Datachannel termination via the new DirectTransport
DataChannel termination via the new DirectTransport
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #400
Feature overview
Allow the Node application to directly send text/binary messages to
mediasoup-worker
C++ process so others can consume them usingDataConsumer
.And vice-versa: allow the Node application to directly consume in Node messages send by
DataProducers
.Implementation
New
DirectTransport
(created viarouter.createDirectTransport
) that uses the newPayloadChannel
(UnixSocket pair between Node and C++) to send payload messages in both directions.Extend
DataProducer
andDataConsumer
classes to not just work with SCTP capable transports (WebRtcTransport
,PlainTransport
,PipeTransport
) but also with the newDirectTransport
.sctpStreamParameters
are now optional inDataProducerOptions
(just valid fordirectTransport.produceData()
).dataProducer/Consumer.sctpStreamParameters
getter can now returnundefined
.Added
dataProducer/Consumer.type
getter, that can be 'sctp' or 'direct'.transport.consumeData()
(when in an SCTP capable transport) now accepts optional SCTP related parameters inDataConsumerOptions
to tell mediasoup how to deliver messages to the remote SCTP endpoint:Worker
: Added a newmessage
log tag.