Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix CLT/xcode version detection exception #413

Merged
merged 1 commit into from
Jun 2, 2020
Merged

fix CLT/xcode version detection exception #413

merged 1 commit into from
Jun 2, 2020

Conversation

enimo
Copy link
Contributor

@enimo enimo commented Jun 2, 2020

fix(worker build): CLT version detect exception without XCode install, more details refers to #410

@ibc
Copy link
Member

ibc commented Jun 2, 2020

Thanks.

@ibc ibc merged commit f741a1c into versatica:v3 Jun 2, 2020
@ibc
Copy link
Member

ibc commented Jun 2, 2020

Released in 3.6.4.

@ibc
Copy link
Member

ibc commented Jun 2, 2020

BTW good work here. Indeed it seems that mediasoup did not even install in Mojave if XCode was not installed: https://mediasoup.discourse.group/t/worker-process-failed-pid-undefined/1169/10

@enimo
Copy link
Contributor Author

enimo commented Jun 3, 2020

Glad to hear this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibc ibc ibc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enimo @ibc