fix srtp_steam leak when closing producer and consumers

[penguinol]

#426

[ibc]

Good catch. Let me take a look since I think the implementation could be a bit different (more simpler). On it. Will ping here soon.

[penguinol]

Good catch. Let me take a look since I think the implementation could be a bit different (more simpler). On it. Will ping here soon.

Yes, the code is a little bit duplicate because srtp session is in the sub class.

[ibc]

Here is an overview of what got changed by this pull request:

Clones added
============
- worker/src/RTC/WebRtcTransport.cpp  2
- worker/src/RTC/PlainTransport.cpp  4
- worker/src/RTC/PipeTransport.cpp  4
         

Clones removed
==============
+ worker/src/RTC/Transport.cpp  -2
+ worker/include/RTC/WebRtcTransport.hpp  -1
         

See the complete overview on Codacy

[ibc]

@penguinol can you please take a look to #428? It's a simpler approach to achieve the same. I've tested it by also printing SRTP streams handled by libsrtp and it works as expected.

[jmillan]

Very nice catch @penguinol

[ibc]

Closing in favour of #428. thanks!

[penguinol]

@penguinol can you please take a look to #428? It's a simpler approach to achieve the same. I've tested it by also printing SRTP streams handled by libsrtp and it works as expected.

Ok, i will test it next week. we have a festival next days.

[ibc]

Don't worry, it's tested, merged and released :)