add MEDIASOUP_MAX_CORES to limit NUM_CORES during build #462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks so much for mediasoup. It's absolutely the best & your dedication to the community is amazing. OSS is hard & thankless, so thank you.
When building in a virtual CI environment,
nproc
could return a very large number of cores. This may cause the kernel to run out of memory when building. While #448 may be a more desirable longterm solution, I understand the additional maintenance cost isn't trivial.This PR allows folks to set a max number of cores to use.
It works like this:
MEDIASOUP_MAX_CORES=8 yarn
.I namespaced the variable because it's possible that other packages might do similar things.
This is hard to test, so I'm including 2 circleCI builds as proof (see "Install Dependencies"):