Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MEDIASOUP_MAX_CORES to limit NUM_CORES during build #462

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

mattkrick
Copy link
Contributor

Thanks so much for mediasoup. It's absolutely the best & your dedication to the community is amazing. OSS is hard & thankless, so thank you.

When building in a virtual CI environment, nproc could return a very large number of cores. This may cause the kernel to run out of memory when building. While #448 may be a more desirable longterm solution, I understand the additional maintenance cost isn't trivial.

This PR allows folks to set a max number of cores to use.
It works like this: MEDIASOUP_MAX_CORES=8 yarn.
I namespaced the variable because it's possible that other packages might do similar things.

This is hard to test, so I'm including 2 circleCI builds as proof (see "Install Dependencies"):

Signed-off-by: Matt Krick <matt.krick@gmail.com>
@ibc
Copy link
Member

ibc commented Sep 11, 2020

Thanks a lot.

@ibc ibc merged commit 3f51ebd into versatica:v3 Sep 11, 2020
@ibc
Copy link
Member

ibc commented Sep 11, 2020

Released in 3.6.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants