-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update modules structure and other minor improvements for Rust version #558
Conversation
… it about intended usage
… placed for conditional modules selection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know Rust myself, but the changes seem to enhance readability and inline documentation.
Considering tests pass I'm OK with the PR.
Pushed an update to fix some of the lints. Do you plan to update libwebrtc to fix |
The problem is within the abseil dependency used by libwebrtc. I Don't think we want to clone it just to avoid this issue, since also there are being some efforts to remove libwebrtc completely from mediasoup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any bad words in the changes so I assume it's ok. Merging.
Changes:
NonClosingProducer
renamed toPipeProducer
with better documentation about why it exists (old name is still available)I will update changelog and bump versions in upcoming PRs once macOS support is merged upstream (hopefully very soon).