Fix build on FreeBSD #585
Merged
Fix build on FreeBSD #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeBSD make and GNU make share a common base but provide extensions not supported by the other. This leads to build failures and can be fixed by using the right version of make. On FreeBSD, GNU make is installed as `gmake` so detect and use this. While here, also check the environment for allowing overriding the binary to make in case other platform can benefit from it (e.g. OpenBSD, NetBSD and probably others). While here, also catch the right number of CPU for parallel build.
jmillan
approved these changes
Jun 11, 2021
ibc
approved these changes
Jun 11, 2021
|
Thanks, will merge later today. |
|
Released in 3.7.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD make and GNU make share a common base but provide extensions
not supported by the other. This leads to build failures and can be
fixed by using the right version of make. On FreeBSD, GNU make is
installed as
gmakeso detect and use this. While here, also checkthe environment for allowing overriding the binary to make in case
other platform can benefit from it (e.g. OpenBSD, NetBSD and probably
others).
While here, also catch the right number of CPU for parallel build.