-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended consumer options to provide way to override MID. #586
Conversation
I'm afraid I cannot review Rust code. Regarding tests, we have tons of test units in |
Code looks perfectly fine, for Rust another test case should be added to |
LGTM, I've just made few cosmetic change requests. |
Adding here too the need for adding the corresponding tests in TS. |
@jmillan could you please suggest next steps to do to make this PR merged? |
I have added a new comment on consumer test. |
8d6d8ad
to
389ab89
Compare
Thanks for the changes. Please wait until Monday for me to do a proper review and merge&release it. |
Released in mediasoup 3.7.16. Thanks! However... a Rust test is failing: https://github.com/mstyura/mediasoup/runs/2873138895?check_suite_focus=true @nazar-pc would you mind taking a look? |
Sorry, ignore. That's not the mediasoup mainstream branch :) |
Nope, of course it also happens in mainstream: https://github.com/versatica/mediasoup/runs/2873156693?check_suite_focus=true |
New Rust version was released and added a new lint. Any warnings cause CI errors, will fix and bump crates versions for publishing. UPD: BTW it literally told you what is wrong, why, how to fix and where to read more about it 🙂 |
This PR is alternative approach to resolve scenario described in #584 in a way suggested by @ibc.
@ibc could you please clarify what test units are requited which you've mentioned in your comment?