Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor memory leak caused by non-virtual destructor in libwebrtc #625

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Fix minor memory leak caused by non-virtual destructor in libwebrtc #625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion worker/deps/libwebrtc/libwebrtc/modules/pacing/paced_sender.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class PacedSender {
PacedSender(PacketRouter* packet_router,
const WebRtcKeyValueConfig* field_trials = nullptr);

~PacedSender() = default;
virtual ~PacedSender() = default;

virtual void CreateProbeCluster(int bitrate_bps, int cluster_id);

Expand Down
2 changes: 1 addition & 1 deletion worker/deps/libwebrtc/libwebrtc/modules/pacing/packet_router.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ namespace webrtc {
class PacketRouter {
public:
PacketRouter() = default;
~PacketRouter() = default;
virtual ~PacketRouter() = default;

virtual void SendPacket(RTC::RtpPacket* packet,
const PacedPacketInfo& cluster_info) = 0;
Expand Down