Add packetLoss stats to transport #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
reviewed
Aug 31, 2021
jmillan
reviewed
Aug 31, 2021
jmillan
reviewed
Aug 31, 2021
nazar-pc
reviewed
Aug 31, 2021
jmillan
approved these changes
Sep 7, 2021
ibc
reviewed
Sep 10, 2021
ibc
reviewed
Sep 10, 2021
ibc
approved these changes
Sep 10, 2021
|
This is merged, however one request more, please. Could you add an example of this new stat in mediasoup-website project in https://mediasoup.org/documentation/v3/mediasoup/rtc-statistics/#WebRtcTransport-Statistics? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One common requirement is to monitor the quality of the user's connections to notify the user and the rest of participants when their connections are not good enough so that they can understand any audio/video issue they can experience during conversations.
This is typically based on packetLoss and/or roundTripTime.
With existing APIs those stats are available per consumer and producer so the application could request all/some of them and aggregate the stats but that can be more efficient and simpler if some of those stats are exposed at transport level.
This PR adds packetLoss as a stat at transport level. The application can retrieve this metric every X seconds and notify the user when its uplink or downlink is bad and also notify rest of participants about it.
The implementation is based on transportCc feedback messages (comparing expected and received values and averaging last 24 of those measurements) so these new stats are only available when transportCC is enabled.