(worker): Modification of Consumer bitrate allocation algorithm #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modification attempts to spread the available bitrate across all Consumers on the first pass. Subsequently it will allocate the excess bitrate to higher priority Consumer.
ibc
reviewed
Nov 3, 2021
worker/src/RTC/Transport.cpp
Outdated
| @@ -2340,6 +2340,26 @@ namespace RTC | |||
| } | |||
| } | |||
|
|
|||
| static inline uint32_t IncreaseConsumerLayer( | |||
There was a problem hiding this comment.
Can we please not move this into a separate method? I don't see any need. We never mix class method with static methods together.
|
The rationale behind this change is outlined in issue Issue 662 The algorithm implemented is outlined in a comment by @vpalmisano |
|
LGTM, I'll recheck tomorrow and merge. |
|
Sorry for the delay, I'm kinda off these days. I'll also involve @jmillan here. |
|
LGTM, I'm just asking @vpalmisano to review this as well since he did the final proposal. |
jmillan
approved these changes
Nov 8, 2021
vpalmisano
approved these changes
Nov 8, 2021
|
Merged, thanks. I'll do a release today. |
|
3.9.2 is out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification attempts to spread the available bitrate across
all Consumers on the first pass. Subsequently it will allocate
the excess bitrate to higher priority Consumers.