Fix update bandwidth estimation configuration and available bitrate when updating max outgoing bitrate #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen updating max outgoing bitrate
ibc
approved these changes
Feb 28, 2022
|
Thanks. Will merge once @jmillan approves. |
jmillan
approved these changes
Mar 1, 2022
|
Release in 3.9.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When updating the max outgoing bitrate we need to update it also in the webrtc bandwidth estimator configuration or it won't be applied until the desired bitrate changes. Also the availableBitrate needs to be updated or the SFU will keep sending a bitrate larger than maxOutgoingBitrate for an undetermined amount of time.
Test Plan:
Ran producer and consumer locally with SVC/Simulcast enabled and configure different maxOutgoingBitrates checking that the forwarded layers change accordingly.