Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RtpStreamSend: Memory optimizations #840

Merged
merged 28 commits into from
Jun 28, 2022
Merged

RtpStreamSend: Memory optimizations #840

merged 28 commits into from
Jun 28, 2022

Commits on Jun 23, 2022

  1. RtpStreamSend: Memory optimizations 

    Essentially extracted from #675

* RtpStreamSend does not clone each RTP packet coming from Producer.
 - A std::shared_ptr holding the original packet is used by all RtpStreamSend
   instances.

* RtpStreamSend does not clone each RTP packet when sending DTX.
 - The original RTP packet is DTX encoded/decoded when needed.

* RtpStreamSend does not store up to 65536 RTP packets in a std::map.
 - Only a limited range of RTP packets are stored in a std::deque.
    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    c5495a6 View commit details
    Browse the repository at this point in the history

  2. be more explicit in condition

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    0dfc5bf View commit details
    Browse the repository at this point in the history

  3. fetch the StorageItem for a packet after cleaning old ones

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    6581ee5 View commit details
    Browse the repository at this point in the history

  4. StorageItem::Reset()

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    44abf0e View commit details
    Browse the repository at this point in the history

  5. StorageItemBuffer::Insert() cleanup 

    Do not return boolean. False was never being returned.
    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    bd2f3bf View commit details
    Browse the repository at this point in the history

  6. Enhance comments

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    9369d31 View commit details
    Browse the repository at this point in the history

  7. Add TODO comments

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    1293f4a View commit details
    Browse the repository at this point in the history

  8. cosmetic: variable initialization

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    38c8fd5 View commit details
    Browse the repository at this point in the history

  9. cleanup test 

    Remove unrelated asserts.
    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    5bb7fd6 View commit details
    Browse the repository at this point in the history

  10. cleanup test

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    780e0d0 View commit details
    Browse the repository at this point in the history

  11. cleanup test

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    37d59aa View commit details
    Browse the repository at this point in the history

  12. add test

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    93fd2e6 View commit details
    Browse the repository at this point in the history

  13. add tests

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    14b7ca6 View commit details
    Browse the repository at this point in the history

  14. cosmetic

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    8c3dbb5 View commit details
    Browse the repository at this point in the history

  15. remove unused Dump methods

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    6e2112b View commit details
    Browse the repository at this point in the history

  16. cosmetic

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    a35a566 View commit details
    Browse the repository at this point in the history

  17. cosmetic

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    460474c View commit details
    Browse the repository at this point in the history

  18. lint

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    def5afe View commit details
    Browse the repository at this point in the history

  19. cosmetic: handle feedback

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    a3b8ac0 View commit details
    Browse the repository at this point in the history

  20. cosmetic: handle feedback

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    4d86ca1 View commit details
    Browse the repository at this point in the history

  21. cosmetic

    @jmillan
    jmillan committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    a807178 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. StorageItemBuffer::Get(); return nullptr if seq < startSeq

    @jmillan
    jmillan committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    6dab5db View commit details
    Browse the repository at this point in the history

  2. cosmetic

    @jmillan
    jmillan committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    8533bda View commit details
    Browse the repository at this point in the history

  3. make cc happy

    @jmillan
    jmillan committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    a67342b View commit details
    Browse the repository at this point in the history

  4. initialize static member in .cpp file

    @jmillan
    jmillan committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    37421c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Router: Clone RtpPacket before forwarding to Consumers 

    So the RtpPacket has its own buffer for future retransmissions.
    @jmillan
    jmillan committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    4dcbea6 View commit details
    Browse the repository at this point in the history

  2. cosmetic: handle feedback

    @jmillan
    jmillan committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    4fc47b3 View commit details
    Browse the repository at this point in the history

  3. update CHANGELOG

    @jmillan
    jmillan committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    71dce12 View commit details
    Browse the repository at this point in the history